Fix issue with failing NodeJS component after the container gets restarted #2265

kadel · 2019-10-09T16:27:59Z

What is the purpose of this change? What does it change?

This fixes the issue where the source code for nodejs was lost after the container was restarted.
This was due to the fact that we removed steps that were coping source files from the /tmp/src directory to /opt/app-root/src.

This updates just the image used by odo, the actual fix is in odo-init-image - redhat-developer/odo-init-image#40

After this is tested. We will release a new odo-init-image, and update this PR to use the released version.

Was the change discussed in an issue?

fixes #2224

How to test changes?

You can download odo binaries build from this PR at https://gcsweb-ci.svc.ci.openshift.org/gcs/origin-ci-test/pr-logs/pull/openshift_odo/2265/pull-ci-openshift-odo-master-v4.1-unit/407/artifacts/unit/dist/bin/

odo component create nodejs
odo url create
odo push
odo config set --env FOO=vv
odo push
# verify that application is still running, previously it did not

or

cd frontend
odo component create nodejs frontend
odo url create
odo push

cd backend
odo component create java backend
odo push

cd frontend
odo link backend --port 8080

# verify that the frontend is running, previously it did not

TODO:

add proper tests

cdrage · 2019-10-09T17:08:38Z

I tested this as well with service listing:

~/nodejs-ex  master ✗                                                                                                          358d ◒  
▶ odo config set --env FOO=BAR
Environment variables were successfully updated.
Run `odo push --config` command to apply changes to the cluster.

~/nodejs-ex  master ✗                                                                                                          358d ◒  
▶ odo push --config
Validation
 ✓  Checking component [21ms]

Configuration changes
 ✓  Retrieving component data [12ms]
 ✓  Applying configuration [12s]

Applying URL changes
 ✓  URL nodejs-nodejs-ex-gymi-8080 already exists

~/nodejs-ex  master ✗                                                                                                          358d ◒  
▶ odo service create mongodb-persistent --plan default --wait -p DATABASE_SERVICE_NAME=mongodb -p MEMORY_LIMIT=512Mi -p MONGODB_DATABASE=sampledb -p VOLUME_CAPACITY=1Gi
 ✓  Creating service [88ms]
 ✓  Waiting for service to come up [37s]
 ✓  Service 'mongodb-persistent' is ready for use

~/nodejs-ex  master ✗                                                                                                          358d ◒  
▶ odo url list
Found the following URLs for component nodejs-nodejs-ex-gymi in application app:
NAME                           STATE      URL                                                                      PORT
nodejs-nodejs-ex-gymi-8080     Pushed     http://nodejs-nodejs-ex-gymi-8080-app-myproject.192.168.42.79.nip.io     8080

~/nodejs-ex  master ✗                                                                                                          358d ◒  
▶ odo link mongodb-persistent
 ✓  Service mongodb-persistent has been successfully linked from the component nodejs-nodejs-ex-gymi

Following environment variables were added to nodejs-nodejs-ex-gymi component:
- admin_password
- database_name
- password
- uri
- username

~/nodejs-ex  master ✗                                                                                                          358d ◒  
▶ ocget pods

~/nodejs-ex  master ✗                                                                                                         358d ◒  ⍉
▶ oc get pods
NAME                                READY     STATUS    RESTARTS   AGE
mongodb-1-2h6mj                     1/1       Running   0          5m
nodejs-nodejs-ex-gymi-app-3-xhfgl   1/1       Running   0          18s

~/nodejs-ex  master ✗                                                                                                          358d ◒  
▶

Works and the application comes up after restarting.

jankleinert · 2019-10-09T17:56:18Z

I'm seeing an issue that I didn't see in a previous version.

git clone https://github.com/openshift-evangelists/Wild-West-Backend
cd Wild-West-Backend
mvn clean package
odo login
odo project create ododemo
odo create java backend --binary target/wildwest-1.0.jar

gives this error:

✗ Rel: can't make target/wildwest-1.0.jar relative to /Users/jkleiner/Downloads/Wild-West-Backend

I did not get that error in odo v1.0.0-beta6 (0cdcc90)

girishramnani · 2019-10-09T18:06:46Z

@jankleinert just to test this PR can you try /Users/jkleiner/Downloads/Wild-West-Backend/target/wildwest-1.0.jar as the --binary's input?

jankleinert · 2019-10-09T19:32:14Z

@girishramnani with that workaround, it did work for me

kadel · 2019-10-10T07:22:43Z

/retest

failed to acquire a resource: Post http://boskos.ci/acquire?dest=leased&owner=ci-op-j758c1yk-1b2f4&request_id=4831054931297018086&state=free&type=aws-quota-slice: dial tcp 172.30.131.17:80: connect: no route to host

kadel · 2019-10-10T08:00:03Z

I'm seeing an issue that I didn't see in a previous version.

git clone https://github.com/openshift-evangelists/Wild-West-Backend
cd Wild-West-Backend
mvn clean package
odo login
odo project create ododemo
odo create java backend --binary target/wildwest-1.0.jar

gives this error:

✗ Rel: can't make target/wildwest-1.0.jar relative to /Users/jkleiner/Downloads/Wild-West-Backend

I did not get that error in odo v1.0.0-beta6 (0cdcc90)

I thought that I saw this error somewhere. Now I remembered that I've opened PR to fix this last week. - #2211 It is just waiting to be merged

kadel · 2019-10-10T09:30:20Z

There is one big problem with this and that is that re-introduces #2171

kadel · 2019-10-10T09:41:51Z

There is one big problem with this and that is that re-introduces #2171

It looks like that cp -p flag is causing this (but only with files that come from Windows).
Fixed by simply removing the flag redhat-developer/odo-init-image@4736f9b
The flag is trying to preserve some file attributes like file modification times, access times, file flags etc. My suspicion is that some of the attributes might not be compatible with volume mount on OpenShift.

dharmit

/approve

Works for me as mentioned in the steps to test. Code LGTM.

/hold so that this doesn't go in before image name is changed after redhat-developer/odo-init-image#40 goes in.

openshift-ci-robot · 2019-10-10T12:13:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/occlient/OWNERS~~ [dharmit]
~~tests/OWNERS~~ [dharmit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cdrage

LGTM from me as well @dharmit

/lgtm

kadel · 2019-10-11T07:20:10Z

/retest

[odo]  ✗  waited 4m0s but couldn't find running pod matching selector: 'deploymentconfig=javaee-war-test-app'

kadel · 2019-10-11T10:07:30Z

/hold cancel

openshift-bot · 2019-10-11T11:41:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added the size/S label Oct 9, 2019

openshift-ci-robot requested review from dharmit and mohammedzee1000 October 9, 2019 16:28

kadel changed the title ~~fix dev-scripts~~ Fix issue with failing NodeJS component after the container gets restarted Oct 9, 2019

kadel added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Oct 9, 2019

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Oct 9, 2019

kadel mentioned this pull request Oct 9, 2019

--binary with relative fails #2266

Closed

kadel force-pushed the fix-dev-scripts branch from 8b63d53 to f162769 Compare October 9, 2019 20:37

kadel added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Oct 10, 2019

kadel force-pushed the fix-dev-scripts branch 2 times, most recently from b1d5140 to 936aaec Compare October 10, 2019 07:57

kadel force-pushed the fix-dev-scripts branch from 936aaec to 2c1f2e0 Compare October 10, 2019 09:07

openshift-ci-robot added size/M and removed size/S labels Oct 10, 2019

dharmit approved these changes Oct 10, 2019

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 10, 2019

openshift-ci-robot assigned cdrage Oct 10, 2019

cdrage reviewed Oct 10, 2019

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 10, 2019

fix dev-scripts and test to verify linking

ae85aee

danielhelfand mentioned this pull request Oct 10, 2019

odo push and odo watch Fail to Update Non Static Content for Node #2272

Closed

user relased odo-init-image 0.13.1

f8463c7

kadel force-pushed the fix-dev-scripts branch from 2c1f2e0 to f8463c7 Compare October 10, 2019 15:58

openshift-ci-robot added size/S and removed size/M labels Oct 10, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Oct 11, 2019

kadel mentioned this pull request Oct 11, 2019

odo push fails for local nodejs component with nodejs:10 and nodejs:latest #2171

Closed

openshift-merge-robot merged commit 8f7d544 into redhat-developer:master Oct 11, 2019

amitkrout mentioned this pull request Oct 11, 2019

Bump odo version to 1.0.0-beta7 #2276

Merged

amitkrout mentioned this pull request Oct 31, 2019

Scenarios that are not tested! #2249

Closed

rm3l added the estimated-size/S (5-10) Rough sizing for Epics. Less then one sprint of work for one person label Jun 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issue with failing NodeJS component after the container gets restarted #2265

Fix issue with failing NodeJS component after the container gets restarted #2265

kadel commented Oct 9, 2019 •

edited by dharmit

cdrage commented Oct 9, 2019

jankleinert commented Oct 9, 2019

girishramnani commented Oct 9, 2019 •

edited

jankleinert commented Oct 9, 2019

kadel commented Oct 10, 2019

kadel commented Oct 10, 2019 •

edited

kadel commented Oct 10, 2019

kadel commented Oct 10, 2019

dharmit left a comment

openshift-ci-robot commented Oct 10, 2019

cdrage left a comment

kadel commented Oct 11, 2019

kadel commented Oct 11, 2019

openshift-bot commented Oct 11, 2019

Fix issue with failing NodeJS component after the container gets restarted #2265

Fix issue with failing NodeJS component after the container gets restarted #2265

Conversation

kadel commented Oct 9, 2019 • edited by dharmit

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

How to test changes?

cdrage commented Oct 9, 2019

jankleinert commented Oct 9, 2019

girishramnani commented Oct 9, 2019 • edited

jankleinert commented Oct 9, 2019

kadel commented Oct 10, 2019

kadel commented Oct 10, 2019 • edited

kadel commented Oct 10, 2019

kadel commented Oct 10, 2019

dharmit left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Oct 10, 2019

cdrage left a comment

Choose a reason for hiding this comment

kadel commented Oct 11, 2019

kadel commented Oct 11, 2019

openshift-bot commented Oct 11, 2019

kadel commented Oct 9, 2019 •

edited by dharmit

girishramnani commented Oct 9, 2019 •

edited

kadel commented Oct 10, 2019 •

edited